x/rustlings
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
916 Commits 1 Branch 0 Tags 2.9 MiB
abd6b70c72
Commit Graph

227 Commits

Author SHA1 Message Date
Taylor Yu
abd6b70c72 feat: add advanced_errs2 
New exercise to demonstrate traits that make it easier for other code
to consume our custom error types.
 2021-09-25 11:18:23 +02:00
Taylor Yu
882d535ba8 feat: add advanced_errs1 
New section and exercise to demonstrate the `From` trait for errors
and its usefulness with the `?` operator.
 2021-09-25 11:18:21 +02:00
Taylor Yu
2dc93cadda fix(from_str, try_from_into): custom error types 
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.

Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
 2021-06-24 21:33:41 -05:00
marisa
a3ea37b76e
Merge pull request #771 from tlyu/iterators5-trait-tweak 
fix(iterators5): derive Clone, Copy
 2021-06-24 14:17:05 +02:00
marisa
ec63cadadb
Merge pull request #772 from tlyu/errors-rework 
feature: improve error_handling exercises
 2021-06-24 14:12:34 +02:00
Taylor Yu
b7ddd09fab address review feedback 
Adjust error text and naming to conform with best practices.
Use `map_err()` instead of `or()`. Wrap lower-level errors instead of
ignoring their details.

Also, don't "cheat" by bypassing the `new()` function in tests.

Fix a dangling reference in the try_from_into hints.
 2021-06-09 23:27:53 -05:00
ZC
48ffcbd2c4
fix(variables5): confine the answer further 
let mut number = 3; can lead to a correct answer, so the comment helps to direct the users to the intended answer.
 2021-06-07 18:22:55 +08:00
Taylor Yu
68d3ac567c feature: improve error_handling exercises 
Add new exercises errors5 and errors6, to introduce boxed errors and
custom error enums more gently. Delete errorsn, because it tried to do
too much too soon.
 2021-06-06 23:08:57 -05:00
Taylor Yu
50ab289da6 fix: rename result1 to errors4 
Also put it in the ERROR HANDLING section where it probably belongs.
 2021-06-06 23:08:54 -05:00
Taylor Yu
91fc9e3118 fix(iterators5): derive Clone, Copy 
To allow more flexibility in solutions, derive `Clone` and `Copy`
for `Progress`.
 2021-06-06 17:38:02 -05:00
Taylor Yu
1b85828548 fix: move_semantics5 hints 
Improve the hints for move_semantics5, as well as the explanatory
comments in the code.

Previously, it was not clear what possible changes were allowed.
It seems that reordering the statements might be the intended solution.
The previous comment about not "adding newlines" doesn't make sense,
so treating it as "adding new lines" makes it more clear.
 2021-05-22 22:09:58 -05:00
Sateesh
399ab328d8
feat: Add move_semantics5 exercise. (#746) 
* feat: Add move_semantics5 exercise.

* feat: Add option3 exercise

* Address review comments. Fix typos, sentence formatting.

* Remove unwanted newline.

* Address review comments: make comment inline, fix format in print.
 2021-05-17 14:10:40 +02:00
Juan Pablo Ramirez
4d4fa77459 fix: remove trailing whitespaces from iterators1 2021-05-12 10:20:07 -05:00
Juan Pablo Ramirez
3145794084 fix: add hints to generics1 and generics2 exercises 2021-05-11 14:50:05 -05:00
Juan Pablo Ramirez
d9b69bd1a0 fix: remove trailing whitespace 2021-05-09 17:58:54 -05:00
Pi Delport
9569c9a9e7
style(standard_library_types): stray line break 2021-04-29 23:31:26 +02:00
Maarten Tibau
650b1dee54
chore: Update quiz1.rs add explicit test for 40 2021-04-25 19:02:50 +02:00
Zerotask
249ad44cc0
docs(exercises): updated all exercises readme files 
all exercises readme files now have a unified structure and a description
 2021-04-23 19:54:31 +02:00
marisa
54804e344d
Merge pull request #721 from Zerotask/add-further-help-for-generics3 
docs(generics): add bounds help
 2021-04-23 15:05:00 +02:00
Zerotask
f253103a31
docs(generics): add bounds help 
add help for bounds provided by the rust by example book
 2021-04-22 22:11:04 +02:00
Zerotask
1120db57a6
docs(errors): add additional help for Result/Boxing 
add additional help information provided by the rust by example book
 2021-04-22 21:32:29 +02:00
Brandon Macer
81be404487
feat(arc1): Add more details to description and hint (#710) 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
 2021-04-21 14:50:03 +02:00
marisa
79cc657917
Merge pull request #646 from apogeeoak/iterator 
Added iterators5.rs exercise.
 2021-04-21 10:10:50 +02:00
apogeeoak
9c88ea9126 Improved iterators5.rs explanation. 2021-04-20 18:55:04 -04:00
marisa
2b766ef9f9
Merge pull request #648 from apogeeoak/iterator2 
Moved iterators2.rs errors out of tests.
 2021-04-20 11:24:10 +02:00
marisa
bd3d9ac9d5
Merge pull request #649 from apogeeoak/iterator3 
Enabled iterators3.rs to run without commented out tests.
 2021-04-20 11:22:39 +02:00
Shao Yang Hong
6bd791f2f4
fix(structs): Add 5.3 to structs/README (#652) 
Co-authored-by: Shao Yang Hong <shaoyang.hong@ninjavan.co>
 2021-04-20 11:19:24 +02:00
k12ish
b4de659438
fix(option2): Rename uninformative variables (#675) 
Renaming uninformative names like `optional_value`, `value`, `optional_values_vec` and `value` helps users distinguish between the two parts of the task.
 2021-04-20 11:18:05 +02:00
Pete Pavlovski
72aaa15e6a
fix(hashmap2): Update incorrect assertion (#660) 
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) 

A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
 2021-04-20 11:15:49 +02:00
Abdou Seck
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main 
Rename 'Lichi' to 'Lychee' in the fruit example
 2021-04-13 10:40:07 -04:00
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming 
Update collections exercises naming
 2021-04-13 10:39:18 -04:00
WowSuchRicky
b790bafc02 Rename lichi to lychee in the fruit example 2021-04-09 14:08:02 -07:00
Taylor Yu
c3e7b83178 fix: use trait objects for from_str 
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate 
errors.
 2021-04-04 18:56:10 -05:00
Taylor Yu
2e93a588e0 fix: use trait objects for try_from_into 
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.  In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
 2021-04-04 12:41:32 -05:00
Ignacio Le Fluk
a6509cc4d5
fix(functions3): improve function argument type (#687) 2021-04-04 09:43:25 +02:00
Rod Elias
3df094713f
chore: capitalize c letter 
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
 2021-03-20 21:12:49 +01:00
Mickael Fortunato
ab9995e76e doc: Update collections exercises instruction to match the standard naming 2021-03-18 19:11:15 +01:00
Mickael Fortunato
bef39b1259 fix(collections): Naming exercises for vectors and hashmap 2021-03-18 19:11:04 +01:00
Pascal H
0d894e6ff7
fix(quiz3): Force an answer to Q2 (#672) 
Add also an example of unimplemented!() macro.
 2021-03-16 10:14:25 +01:00
Pascal H
3bce2ef8d6
chore: clarify collections documentation 
C++ `map` is more like BTreeMap.

`unordered_map` in C++(11) is the equivalent of `HashMap` in Rust.
(+ additional like for references).
 2021-03-15 09:14:12 +01:00
Darius Wiles
9f3e8c2dde
fix(structs3): reword heading comment (#664) 2021-03-13 12:14:02 +01:00
cadolphs
05a753fe63
fix: add check to prevent naive implementation of is_international 
* fix(structs3): Add check to prevent naive implementation

* chore(structs3): Add a missed newline after the test I added
 2021-03-12 18:36:35 +01:00
Jirka Kremser
5f7c89f85d
fix(from_str): Correct typos 
typos in the comments
 2021-02-21 21:50:17 +01:00
apogeeoak
c6712dfccd fix(iterators3): Enabled iterators3.rs to run without commented out tests. 2021-02-12 15:36:53 -05:00
apogeeoak
baf4ba175b fix(iterators2): Moved errors out of tests. 
Closes #359
 2021-02-11 21:24:32 -05:00
apogeeoak
b29ea17ea9 feat: Added iterators5.rs exercise. 2021-02-10 18:03:29 -05:00
Tal
cc266d7d80
fix(move_semantics4): Remove redundant "instead" (#640) 2021-02-07 12:22:13 +01:00
Jean-Francois Chevrette
15e71535f3 fix(from_str): test for error instead of unwrap/should_panic 2021-01-21 07:55:22 -05:00
Sang-Heon Jeon
4f1374a6e7 feat(from_into) : add test for checking unnecessary trailing value 2021-01-09 00:08:38 +09:00
Sang-Heon Jeon
5a0521e92c feat(from_str) : add test for checking unnecessary trailing value 2021-01-09 00:07:13 +09:00